Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change rust-version in Cargo.toml to comply with MSRV #7107

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

sarutak
Copy link
Member

@sarutak sarutak commented Jul 26, 2023

Which issue does this PR close?

Closes #7106

Rationale for this change

As I explained in #7106, we can't build datafusion with Rust 1.64 which is specified in Cargo.toml.

What changes are included in this PR?

Changed rust-version in Cargo.toml. I decided the version as reported by cargo msrv.

Are these changes tested?

Confirmed I can build with Rust 1.70.

Are there any user-facing changes?

No.

@alamb
Copy link
Contributor

alamb commented Jul 27, 2023

Thank you very much @sarutak

There was a similar issue apache/arrow-rs#4487 on arrow-rs a few weeks ago and part of that PR was to add a CI check to ensure the msrv was valid.

Are you willing to try and add such a check for DataFusion so the toml file doesn't drift out of sync again?

@alamb alamb merged commit 8450544 into apache:main Jul 27, 2023
@sarutak
Copy link
Member Author

sarutak commented Jul 27, 2023

@alamb

There was a similar issue apache/arrow-rs#4487 on arrow-rs a few weeks ago and part of that PR was to add a CI check to ensure the msrv was valid.

Are you willing to try and add such a check for DataFusion so the toml file doesn't drift out of sync again?

Thank you for letting me know!
It's nice to have, and I'll try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't build with Rust 1.64
2 participants