Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AnalysisContext and statistics() of FilterExec #6982

Merged
merged 51 commits into from
Jul 20, 2023
Merged

Refactor AnalysisContext and statistics() of FilterExec #6982

merged 51 commits into from
Jul 20, 2023

Commits on May 31, 2023

  1. Min/Max in ExprBoundaries are replaced with Interval

    @berkaysynnada
    berkaysynnada committed May 31, 2023
    Configuration menu
    Copy the full SHA
    906fd27 View commit details
    Browse the repository at this point in the history

  2. Minor fix

    @berkaysynnada
    berkaysynnada committed May 31, 2023
    Configuration menu
    Copy the full SHA
    90a1423 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into feature/refactor-analysis-context

    @berkaysynnada
    berkaysynnada committed May 31, 2023
    Configuration menu
    Copy the full SHA
    f460f57 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. min max values replaced by intervals, analyze() computations are done… 

    … with intervals
    @berkaysynnada
    berkaysynnada committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    3fd57b3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/refactor-analysis-context

    @berkaysynnada
    berkaysynnada committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    c8c2fb6 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. Floating points are computed more wisely

    @berkaysynnada
    berkaysynnada committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    79c8f0d View commit details
    Browse the repository at this point in the history

  2. simplifications

    @mustafasrepo
    mustafasrepo committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    7c5c678 View commit details
    Browse the repository at this point in the history

  3. simplifications

    @mustafasrepo
    mustafasrepo committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    71f1854 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. Floating point selectivity is calculated considering interval cardina… 

    …lities.
    @berkaysynnada
    berkaysynnada committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    a7391df View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/refactor-analysis-context

    @berkaysynnada
    berkaysynnada committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    0020120 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. Interval ranges are calculated with cp_solver lib

    @berkaysynnada
    berkaysynnada committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    8b7d45a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/refactor-analysis-context

    @berkaysynnada
    berkaysynnada committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    754fa02 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. Merge branch 'main' into feature/refactor-analysis-context

    @berkaysynnada
    berkaysynnada committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    3f1db69 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2023

  1. Remove the float equality case due to diverse result of windows test

    @berkaysynnada
    berkaysynnada committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    d10182a View commit details
    Browse the repository at this point in the history

  2. Revert "Remove the float equality case due to diverse result of windo… 

    …ws test"

This reverts commit d10182a.
    @berkaysynnada
    berkaysynnada committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    f69329c View commit details
    Browse the repository at this point in the history

  3. No need to assign literal intervals

    @berkaysynnada
    berkaysynnada committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    61df191 View commit details
    Browse the repository at this point in the history

  4. clean clone

    @berkaysynnada
    berkaysynnada committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    3724336 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into feature/refactor-analysis-context

    @berkaysynnada
    berkaysynnada committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    63e370a View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Multi columns may be evaluated in some cases, cont'd

    @berkaysynnada
    berkaysynnada committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    46c5340 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. First iteration of refactoring 

    1) Analyze is removed from the methods of PhysicalExpr.
2) Interval arithmetic is applied to AnalysisContext values.
3) Intervals of input columns are updated now.
    @berkaysynnada
    berkaysynnada committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    6ca74bd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/refactor-analysis-context

    @berkaysynnada
    berkaysynnada committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    aaf8691 View commit details
    Browse the repository at this point in the history

  3. Linter fix

    @berkaysynnada
    berkaysynnada committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    85bcea3 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Merge branch 'main' into feature/refactor-analysis-context

    @berkaysynnada
    berkaysynnada committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    45f16e4 View commit details
    Browse the repository at this point in the history

  2. Tests added, bugs fixed

    @berkaysynnada
    berkaysynnada committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    5a0fe3b View commit details
    Browse the repository at this point in the history

  3. Refactor on code

    @metesynnada
    metesynnada committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    6edfa83 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Refactor of functions, fix for win tests

    @berkaysynnada
    berkaysynnada committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    e05d3be View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. minor changes

    @mustafasrepo
    mustafasrepo committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    2cfcb74 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Merge branch 'main' into feature/refactor-analysis-context 

    # Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
minor changes
    @mustafasrepo
    mustafasrepo committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    21ffcce View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/refactor-analysis-context

    @berkaysynnada
    berkaysynnada committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    b702521 View commit details
    Browse the repository at this point in the history

  3. Comments enriched

    @berkaysynnada
    berkaysynnada committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    f72c790 View commit details
    Browse the repository at this point in the history

  4. Simplify collect_statistics

    @mustafasrepo
    mustafasrepo committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    c07e723 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'feature/refactor-analysis-context' of https://github.co… 

    …m/synnada-ai/arrow-datafusion into feature/refactor-analysis-context
    @mustafasrepo
    mustafasrepo committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    88889cc View commit details
    Browse the repository at this point in the history

  6. Comment added for float value's selectivity

    @berkaysynnada
    berkaysynnada committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    288c852 View commit details
    Browse the repository at this point in the history

  7. Remove code duplication

    @mustafasrepo
    mustafasrepo committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    746b7fe View commit details
    Browse the repository at this point in the history

  8. Merge branch 'feature/refactor-analysis-context' of https://github.co… 

    …m/synnada-ai/arrow-datafusion into feature/refactor-analysis-context
    @mustafasrepo
    mustafasrepo committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    33522d7 View commit details
    Browse the repository at this point in the history

  9. Update datafusion/physical-expr/src/intervals/interval_aritmetic.rs 

    Co-authored-by: Mehmet Ozan Kabak <[email protected]>
    @berkaysynnada @ozankabak
    berkaysynnada and ozankabak authored Jul 14, 2023
    Configuration menu
    Copy the full SHA
    0860b54 View commit details
    Browse the repository at this point in the history

  10. Update datafusion/physical-expr/src/intervals/interval_aritmetic.rs 

    Co-authored-by: Mehmet Ozan Kabak <[email protected]>
    @berkaysynnada @ozankabak
    berkaysynnada and ozankabak authored Jul 14, 2023
    Configuration menu
    Copy the full SHA
    b25ee81 View commit details
    Browse the repository at this point in the history

  11. Update datafusion/physical-expr/src/intervals/interval_aritmetic.rs 

    Co-authored-by: Mehmet Ozan Kabak <[email protected]>
    @berkaysynnada @ozankabak
    berkaysynnada and ozankabak authored Jul 14, 2023
    Configuration menu
    Copy the full SHA
    f6fc686 View commit details
    Browse the repository at this point in the history

  12. Update datafusion/physical-expr/src/intervals/interval_aritmetic.rs 

    Co-authored-by: Mehmet Ozan Kabak <[email protected]>
    @berkaysynnada @ozankabak
    berkaysynnada and ozankabak authored Jul 14, 2023
    Configuration menu
    Copy the full SHA
    0c84002 View commit details
    Browse the repository at this point in the history

  13. Update datafusion/physical-expr/src/physical_expr.rs 

    Co-authored-by: Mehmet Ozan Kabak <[email protected]>
    @berkaysynnada @ozankabak
    berkaysynnada and ozankabak authored Jul 14, 2023
    Configuration menu
    Copy the full SHA
    b88959c View commit details
    Browse the repository at this point in the history

  14. Update datafusion/physical-expr/src/physical_expr.rs 

    Co-authored-by: Mehmet Ozan Kabak <[email protected]>
    @berkaysynnada @ozankabak
    berkaysynnada and ozankabak authored Jul 14, 2023
    Configuration menu
    Copy the full SHA
    30170e8 View commit details
    Browse the repository at this point in the history

  15. Update datafusion/physical-expr/src/physical_expr.rs 

    Co-authored-by: Mehmet Ozan Kabak <[email protected]>
    @berkaysynnada @ozankabak
    berkaysynnada and ozankabak authored Jul 14, 2023
    Configuration menu
    Copy the full SHA
    fb780b4 View commit details
    Browse the repository at this point in the history

  16. Update datafusion/physical-expr/src/intervals/interval_aritmetic.rs 

    Co-authored-by: Mehmet Ozan Kabak <[email protected]>
    @berkaysynnada @ozankabak
    berkaysynnada and ozankabak authored Jul 14, 2023
    Configuration menu
    Copy the full SHA
    0a619bf View commit details
    Browse the repository at this point in the history

  17. Comments added

    @berkaysynnada
    berkaysynnada committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    dce7463 View commit details
    Browse the repository at this point in the history

  18. Merge branch 'feature/refactor-analysis-context' of https://github.co… 

    …m/synnada-ai/arrow-datafusion into feature/refactor-analysis-context
    @berkaysynnada
    berkaysynnada committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    f3cda5d View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Minor improvements

    @berkaysynnada
    berkaysynnada committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    79f9baf View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/refactor-analysis-context

    @berkaysynnada
    berkaysynnada committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    ff9faed View commit details
    Browse the repository at this point in the history

  3. Clippy

    @berkaysynnada
    berkaysynnada committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    dec7e7d View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. next_value func moves to interval module

    @berkaysynnada
    berkaysynnada committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    c5640a5 View commit details
    Browse the repository at this point in the history

  2. Reverts next_value(), adds test

    @berkaysynnada
    berkaysynnada committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    109eb78 View commit details
    Browse the repository at this point in the history

  3. Final review

    @ozankabak
    ozankabak committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    6d29b7b View commit details
    Browse the repository at this point in the history