Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR]: Add GroupByOrderMode to the AggregateExec display #6141

Merged
merged 2 commits into from
Apr 27, 2023
Merged

[MINOR]: Add GroupByOrderMode to the AggregateExec display #6141

merged 2 commits into from
Apr 27, 2023

Conversation

mustafasrepo
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

In the discussion. We agreed that it is useful to have GroupByOrderMode, in the display of AggregateExec. This PR adds this information to the display (if applicable).

What changes are included in this PR?

Are these changes tested?

Display of the existing tests that have ordering is changed.

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels Apr 27, 2023
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thank you @mustafasrepo

@alamb alamb changed the title MINOR]: Add GroupByOrderMode to the AggregateExec display [MINOR]: Add GroupByOrderMode to the AggregateExec display Apr 27, 2023
@alamb alamb merged commit 419adf0 into apache:main Apr 27, 2023
@mustafasrepo mustafasrepo deleted the feature/groupby_ordermode branch June 2, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants