fix: support date - timestamp and timestamp - date
#5960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
jackwener
force-pushed
the
date_minus
branch
2 times, most recently
from
24fbb70
to
908055e
Compare
jackwener
commented
Apr 11, 2023
| @@ -88,3 +88,19 @@ h | |||
| statement error DataFusion error: Error during planning: Timestamp\(Nanosecond, Some\("\+00:00"\)\) \+ Utf8 can't be evaluated because there isn't a common type to coerce the types to | |||
| select i_item_desc from test | |||
| where d3_date > now() + '5 days'; | |||
|
|
|||
| # DATE minus DATE | |||
There was a problem hiding this comment.
I have a idea, maybe we can add a type_coercion.slt.
I prepare to add it in next PR.
There was a problem hiding this comment.
Great, btw we already have array_typeof.slt which also covers some casts
comphead
reviewed
Apr 11, 2023
ozankabak
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
Thank you @jackwener, LGTM. @berkaysynnada can chime in if there is anything I'm missing
alamb
changed the title
date - timestamp and timestamp - date
alamb
approved these changes
Apr 11, 2023
| 0 years 0 mons 0 days 0 hours 0 mins 0.000000000 secs | ||
|
|
||
| # large timestamp - small timestamp | ||
| # Todo: Does it need to be fixed for negative values?. |
There was a problem hiding this comment.
I think negative values is correct and a valid interval. The intervals are signed according to the arrow spec:
| @@ -754,51 +751,6 @@ fn temporal_coercion(lhs_type: &DataType, rhs_type: &DataType) -> Option<DataTyp | |||
| } | |||
| } | |||
|
|
|||
| /// Coercion rule for numerical types: The type that both lhs and rhs | |||
There was a problem hiding this comment.
it is always nice to see a bug fixed by deleting code. Thank you @jackwener 👏
|
Thanks everyone❤️ |
korowa
pushed a commit
to korowa/arrow-datafusion
that referenced
this pull request
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5931 .
Rationale for this change
support data/timestamp minus in type coercion.
What changes are included in this PR?
Add test in slt.
Are these changes tested?
Are there any user-facing changes?