-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate new projection plan in inline_table_scan instead of discarding #5371
Conversation
👍 can we add a test as well? |
Added it. Thanks for reviewing. Original inside-scan just own one field, I add another one field. So, when table-scan projection is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this code looks fine, but I don't understand the rationale for the change (e.g none of the overall plans changed) Maybe it is part of a larger project?
Yes! It's related with this #5366. When I try to eliminate unnecessary projection. If we always projection all column, it will cause a bug.
|
Thanks @Dandandan and @alamb |
Benchmark runs are scheduled for baseline = 3b8b94e and contender = 095f934. 095f934 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
…ng (apache#5371) * fix inline_table_scan * add test
Which issue does this PR close?
Closes #.
Rationale for this change
In origin rule, we will discard all
projection
intable_scan
.This isn't a best choice. we can remain it.
What changes are included in this PR?
generate new
projection
plan accord by originalprojection
intable_scan
.Are these changes tested?
Are there any user-facing changes?