Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix TableScan may contain fields not included in schema #5188

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

jackwener
Copy link
Member

@jackwener jackwener commented Feb 6, 2023

Which issue does this PR close?

Closes #4793.

Rationale for this change

What changes are included in this PR?

When tablescan projection don't contain field in scan-projection, we should push them into scan-projection

Are these changes tested?

Don't need more test.

In the future, we will disable skipfail in optimizer. This PR will be test by filter_pushdown_view

Are there any user-facing changes?

@jackwener
Copy link
Member Author

cc @HaoYang670

@github-actions github-actions bot added the optimizer Optimizer rules label Feb 6, 2023
@HaoYang670
Copy link
Contributor

Thank you @jackwener. I'll review this tomorrow. (working overtime today 😂)

Copy link
Contributor

@HaoYang670 HaoYang670 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jackwener. I've run the test filter_pushdown_view locally with setting skip_failed_rules = false, and the test could pass.

datafusion/optimizer/src/push_down_projection.rs Outdated Show resolved Hide resolved
Co-authored-by: Remzi Yang <[email protected]>
@jackwener jackwener merged commit e222bd6 into apache:master Feb 7, 2023
@jackwener jackwener deleted the fix_filter branch February 7, 2023 14:49
@ursabot
Copy link

ursabot commented Feb 7, 2023

Benchmark runs are scheduled for baseline = 61459d9 and contender = e222bd6. e222bd6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimizer Optimizer rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The filters expressions in TableScan may contain fields not included in schema.
3 participants