Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken CI on git diff: Not a git repository #5182

Closed
wants to merge 1 commit into from

Conversation

viirya
Copy link
Member

@viirya viirya commented Feb 4, 2023

Which issue does this PR close?

Closes #5180.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@viirya viirya changed the title Fix CI CI is currently broken on git diff: Not a git repository Feb 4, 2023
@viirya
Copy link
Member Author

viirya commented Feb 4, 2023

@viirya viirya changed the title CI is currently broken on git diff: Not a git repository Fix broken CI on git diff: Not a git repository Feb 4, 2023
@viirya viirya changed the title Fix broken CI on git diff: Not a git repository Fix broken CI on git diff: Not a git repository Feb 4, 2023
@tustvold
Copy link
Contributor

tustvold commented Feb 5, 2023

Perhaps I'm biased, but I think #5177 is cleaner

@jackwener
Copy link
Member

jackwener commented Feb 5, 2023

After merge #5177, look like we can close this.
Thanks @tustvold and @viirya ❤️

@jackwener jackwener closed this Feb 5, 2023
@viirya viirya deleted the try_fix_ci branch February 5, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI is currently broken on git diff: Not a git repository
3 participants