Cleanup InformationSchema plumbing #4740
Conversation
| @@ -20,7 +20,7 @@ | |||
|
|
|||
| #![allow(clippy::module_inception)] | |||
| pub mod catalog; | |||
| pub mod information_schema; | |||
| pub(crate) mod information_schema; | |||
There was a problem hiding this comment.
There wasn't anything public in the module so we might as well just make it crate private
https://docs.rs/datafusion/latest/datafusion/catalog/information_schema/index.html
| @@ -1721,6 +1653,12 @@ impl SessionState { | |||
| table_ref: impl Into<TableReference<'a>>, | |||
| ) -> Result<Arc<dyn SchemaProvider>> { | |||
| let resolved_ref = self.resolve_table_ref(table_ref); | |||
| if self.config.information_schema() && resolved_ref.schema == INFORMATION_SCHEMA { | |||
| return Ok(Arc::new(InformationSchemaProvider::new( | |||
There was a problem hiding this comment.
This is cool -- it makes the information schema provider on demand 👍
There was a problem hiding this comment.
There is good test coverage of information schema in https://github.com/apache/arrow-datafusion/blob/master/datafusion/core/tests/sql/information_schema.rs and https://github.com/apache/arrow-datafusion/blob/master/datafusion/core/tests/sqllogictests/test_files/information_schema.slt
Thank you for the cleanup @tustvold
|
Benchmark runs are scheduled for baseline = 9046a8a and contender = 8c0c0ad. 8c0c0ad is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #.
Rationale for this change
This follows on from #4606 and #4722 and simplifies the handling of information schema
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?