-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace the comparison op for decimal array op using the arrow-rs kernel #4290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
Looks great to me -- thanks @liukun4515
@@ -516,42 +451,7 @@ mod tests { | |||
25, | |||
3, | |||
); | |||
// eq: left == right |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move these test to the test of binary.rs
file. cc @alamb
@@ -2384,25 +2382,90 @@ mod tests { | |||
) | |||
.unwrap(); | |||
|
|||
// compare decimal array with other array type | |||
let value: i128 = 123; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
migrate the test in kernels_arrow.rs
to here
CI failure due to #4294 (not this PR) |
Benchmark runs are scheduled for baseline = 71e345f and contender = 60d9bbe. 60d9bbe is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
part of #4289
We will replace the arithmetic op later in the follow-up pr.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?