Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace the comparison op for decimal array op using the arrow-rs kernel #4290

Merged
merged 3 commits into from
Nov 20, 2022

Conversation

liukun4515
Copy link
Contributor

Which issue does this PR close?

part of #4289

We will replace the arithmetic op later in the follow-up pr.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the physical-expr Physical Expressions label Nov 19, 2022
@liukun4515 liukun4515 requested a review from alamb November 19, 2022 09:03
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

Looks great to me -- thanks @liukun4515

@@ -516,42 +451,7 @@ mod tests {
25,
3,
);
// eq: left == right
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move these test to the test of binary.rs file. cc @alamb

@@ -2384,25 +2382,90 @@ mod tests {
)
.unwrap();

// compare decimal array with other array type
let value: i128 = 123;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

migrate the test in kernels_arrow.rs to here

@alamb
Copy link
Contributor

alamb commented Nov 20, 2022

CI failure due to #4294 (not this PR)

@alamb alamb merged commit 60d9bbe into apache:master Nov 20, 2022
@ursabot
Copy link

ursabot commented Nov 20, 2022

Benchmark runs are scheduled for baseline = 71e345f and contender = 60d9bbe. 60d9bbe is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@liukun4515 liukun4515 deleted the kernel_logical_datafusion branch November 22, 2022 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
physical-expr Physical Expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants