Re-export Arrow and Parquet crates from DataFusion #39
Conversation
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
=======================================
Coverage 75.83% 75.83%
=======================================
Files 135 135
Lines 23152 23152
=======================================
Hits 17557 17557
Misses 5595 5595
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
LGTM. Thanks a lot, @returnString !
Could you rebase / address conflicts?
returnString
force-pushed
the
reexported_deps
branch
from
1ddbbf4 to
71ca19a
Compare
|
No problem at all :) Just rebased to fix up the conflicts with the benchmark refactoring. |
|
I merged this into master locally and the tests pass so I will merge this. Thanks @returnString ! |
houqp
added
enhancement
…regation (#12946) * Improve unparsing for ORDER BY with Aggregation functions (#38) * Improve UNION unparsing (#39) * Scalar functions in ORDER BY unparsing support (#41) * Improve unparsing for complex Window functions with Aggregation (#42) * WindowFunction order_by should respect `supports_nulls_first_in_sort` dialect setting (#43) * Fix plan_to_sql * Improve
Which issue does this PR close?
Closes #36.
What changes are included in this PR?
datafusioncrate now re-exports its versions ofarrowandparquetbenchmarksanddatafusion-examplescrates have been updated to make use of these exports in lieu of declaring their own dependencies on thearrow-rsrepoBonus subsection: not changed
datafusion-examplesstill manually depends on thearrow-rsrepo for Flight support, as DataFusion doesn't use this currentlyAre there any user-facing changes?
This only provides users with an extra option for referencing
arrowandparquet, without breaking existing setups - we should probably add this to an installation/usage section of the user guide once that settles a bit though.