-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to arrow 22 #3363
Upgrade to arrow 22 #3363
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3363 +/- ##
==========================================
- Coverage 85.51% 85.50% -0.01%
==========================================
Files 294 294
Lines 54120 54115 -5
==========================================
- Hits 46279 46272 -7
- Misses 7841 7843 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@alamb thanks for releasing arrow 22! Hopefully this helps release the next version of DataFusion :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm slightly concerned about discarding the StringBuilder
capacity. StringBuilder::with_capacity(num_of_items, 1024)
seems a better choice for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- thank you @avantgardnerio ❤️
Let me know if you want to make any additional changes otherwise I will plan to merge this in later today or tomorrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks @avantgardnerio!
If CI passes, I think all feedback has been addressed. |
CI seems broken. @alamb or @andygrove appreciate it if you could kick it please. |
Okay, ready for merge. No idea why github is taking so long today... |
Thanks @avantgardnerio! |
Benchmark runs are scheduled for baseline = c89b10f and contender = d16457a. d16457a is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #3362.
Rationale for this change
We should keep DataFusion up to date with Arrow.
What changes are included in this PR?
new()
and otherswith_capacity()
Are there any user-facing changes?
No