Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use concat_elements_utf8 from arrow rather than custom kernel #3036

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Aug 4, 2022

Which issue does this PR close?

re #1474

Rationale for this change

I noticed #3026 (comment) that datafusion is not yet using the great concat_elements kernel added by @ismailmaj in apache/arrow-rs#1720

What changes are included in this PR?

Use arrow kernel, remove custom datafusion one

Are there any user-facing changes?

No

@github-actions github-actions bot added the physical-expr Physical Expressions label Aug 4, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3036 (c77ef6c) into master (d07a775) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3036      +/-   ##
==========================================
- Coverage   85.85%   85.84%   -0.01%     
==========================================
  Files         286      286              
  Lines       51670    51658      -12     
==========================================
- Hits        44360    44347      -13     
- Misses       7310     7311       +1     
Impacted Files Coverage Δ
...on/physical-expr/src/expressions/binary/kernels.rs 63.15% <ø> (-8.85%) ⬇️
datafusion/physical-expr/src/expressions/binary.rs 97.88% <100.00%> (ø)
datafusion/expr/src/window_frame.rs 92.43% <0.00%> (-0.85%) ⬇️
datafusion/expr/src/logical_plan/plan.rs 77.60% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@alamb alamb marked this pull request as ready for review August 4, 2022 17:41
@alamb alamb merged commit b2be7ab into apache:master Aug 4, 2022
@ursabot
Copy link

ursabot commented Aug 4, 2022

Benchmark runs are scheduled for baseline = d07a775 and contender = b2be7ab. b2be7ab is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb deleted the alamb/use_kernel branch August 8, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
physical-expr Physical Expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants