Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant docker argument #2752

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Conversation

avantgardnerio
Copy link
Contributor

Which issue does this PR close?

Closes issue #2751 .

Rationale for this change

Minor syntax fix to restore previous functionality.

Are there any user-facing changes?

No

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reproduced the issue locally and confirmed that this PR fixes it. Thanks @avantgardnerio

@andygrove
Copy link
Member

@xudong963 fyi

@codecov-commenter
Copy link

Codecov Report

Merging #2752 (50c9f8a) into master (3f4aaab) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 50c9f8a differs from pull request most recent head 29942f4. Consider uploading reports for the commit 29942f4 to get more accurate results

@@            Coverage Diff             @@
##           master    #2752      +/-   ##
==========================================
- Coverage   84.96%   84.95%   -0.01%     
==========================================
  Files         271      271              
  Lines       48053    48053              
==========================================
- Hits        40827    40824       -3     
- Misses       7226     7229       +3     
Impacted Files Coverage Δ
datafusion/optimizer/src/utils.rs 33.68% <0.00%> (-0.53%) ⬇️
datafusion/expr/src/logical_plan/plan.rs 73.71% <0.00%> (-0.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f4aaab...29942f4. Read the comment docs.

Copy link
Member

@xudong963 xudong963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xudong963 xudong963 merged commit 4153d88 into apache:master Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants