Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use parquet predicates for indexed fields #2724

Conversation

nl5887
Copy link
Contributor

@nl5887 nl5887 commented Jun 12, 2022

Currently indexed fields are not supported, causing predicate_evaluation_errors and silently ignoring the predicate. This fix will add support for indexed fields.

@github-actions github-actions bot added the core Core DataFusion crate label Jun 12, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2724 (77beccd) into master (ed0fe8c) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##           master    #2724   +/-   ##
=======================================
  Coverage   84.70%   84.70%           
=======================================
  Files         270      270           
  Lines       47262    47266    +4     
=======================================
+ Hits        40035    40039    +4     
  Misses       7227     7227           
Impacted Files Coverage Δ
datafusion/core/src/physical_optimizer/pruning.rs 93.48% <50.00%> (-0.29%) ⬇️
datafusion/expr/src/logical_plan/plan.rs 73.91% <0.00%> (+0.19%) ⬆️
datafusion/optimizer/src/utils.rs 32.79% <0.00%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed0fe8c...77beccd. Read the comment docs.

Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we get a test for this, I'm honestly not entirely sure what this is actually doing 😅

@alamb alamb marked this pull request as draft July 2, 2022 11:14
@alamb
Copy link
Contributor

alamb commented Jul 2, 2022

Marking as draft to make it clear it is waiting for some tests -- please mark it ready for review when it is ready for review again. Thanks @nl5887 !

@alamb
Copy link
Contributor

alamb commented Jan 14, 2023

This PR is more than 6 month old, so closing it down for now to clean up the PR list. Please reopen if this is a mistake and you plan to work on it more

@alamb alamb closed this Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants