Improve sql integration test organization #2333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Apr 25, 2022
| @@ -496,53 +496,49 @@ async fn group_by_date_trunc() -> Result<()> { | |||
|
|
|||
| #[tokio::test] | |||
| async fn group_by_largeutf8() { | |||
| { | |||
| let ctx = SessionContext::new(); | |||
| let ctx = SessionContext::new(); | |||
There was a problem hiding this comment.
This change just removes an extra level of (unecessary) indent
It is easier to see the change with https://github.com/apache/arrow-datafusion/pull/2333/files?w=1
alamb
changed the title
yjshen
approved these changes
Apr 25, 2022
xudong963
approved these changes
Apr 25, 2022
andygrove
approved these changes
Apr 25, 2022
jimexist
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
re #2328
Minor follow on to #2329
Rationale for this change
@WinkerDu moved most of the tests out of context ❤️ into sql_integ test which is a much better place. However I think some of the tests could be in slightly different modules.
What changes are included in this PR?
Move some code around, no functional changes intended
Are there any user-facing changes?
No, test only change