Serialize timezone in timestamp scalar values #2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Mar 29, 2022
Comment on lines
+582
to
+586
| let timezone = if v.timezone.is_empty() { | ||
| None | ||
| } else { | ||
| Some(v.timezone.clone()) | ||
| }; |
There was a problem hiding this comment.
Maybe it could be written like this:
Suggested change
| let timezone = if v.timezone.is_empty() { | |
| None | |
| } else { | |
| Some(v.timezone.clone()) | |
| }; | |
| let timezone = v.timezone.map(|v| Some(v.clone()))? |
There was a problem hiding this comment.
Maybe it could be written like this:
In this case v.timezone is a String. Rather than introduce a wrapper type to make an optional string field, this is just interpreting an empty string as None.
| Value::IntervalYearmonthValue(v) => Self::IntervalYearMonth(Some(*v)), | ||
| Value::IntervalDaytimeValue(v) => Self::IntervalDayTime(Some(*v)), | ||
| Value::TimestampValue(v) => { |
There was a problem hiding this comment.
the replication is unfortunate but I see it is not something that got introduced with this PR
yjshen
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2116
Rationale for this change
Optional timezone was not being serialized in the standard protobuf serialization of
ScalarValueWhat changes are included in this PR?
Add timezone to the protobuf definitions and handle serialization/deserialization
Are there any user-facing changes?
No
No