Add test in register_catalog and change to use named symbolic constants #2050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Mar 21, 2022
datafusion/src/execution/context.rs
Outdated
| catalog, | ||
| )), | ||
| } | ||
| Arc::new(CatalogWithInformationSchema::new( |
There was a problem hiding this comment.
This is the fix -- I did not understand what this special case was for (and all the tests seem to pass without it). It seems like this code will basically ignore the catalog parameter passed in if it finds an existing information_schema which doesn't seem correct to me
@matthewmturner do you remember why it was added in #1959?
…n" and information schema enabled
alamb
force-pushed
the
alamb/fix_register_schema
branch
from
f3f5765 to
7adcfba
Compare
alamb
changed the title
yjshen
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2049
Rationale for this change
codepanic!if information table is enabled but default catalog is named something differentUpdate: 🤔 the bug seems to have been fixed in #2029 -- I still think this PR has value to add tests
What changes are included in this PR?
Fix panicAre there any user-facing changes?