Eliminate the scalar value filter #2002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @Dandandan @houqp ❤ |
Dandandan
reviewed
Mar 13, 2022
jackwener
force-pushed
the
eliminate_false
branch
from
2771629 to
f6021c3
Compare
Ted-Jiang
reviewed
Mar 13, 2022
| }) => { | ||
| if !*v { | ||
| return Ok(LogicalPlan::EmptyRelation(EmptyRelation { | ||
| produce_one_row: false, |
There was a problem hiding this comment.
i have checked in pg , it will return 0 row. 👍
postgres=# select 1 from user_tbl where false;
?column?
----------
(0 rows)
postgres=# select * from user_tbl where false;
name | signup_date
------+-------------
(0 rows)
Dandandan
approved these changes
Mar 13, 2022
jackwener
changed the title
false filter
houqp
approved these changes
Mar 14, 2022
liukun4515
approved these changes
Mar 14, 2022
|
Thanks @jackwener |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1724.
What changes are included in this PR?
Add rule
eliminate_filter, which can eliminate the filter using scalar and add unit test.Are there any user-facing changes?
None.