Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename sql integration tests from mod to sql_integration #1575

Merged
merged 1 commit into from
Jan 16, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jan 15, 2022

Which issue does this PR close?

Closes #1574

DataFusion has a large library of sql integration tests

They are currently run via

cargo test -p datafusion --test mod

(Or cargo test)

which is quite confusing as the name mod is somewhat silly. They used to be run via

cargo test -p datafusion --test sql

**Changes **
Rename the tests so they run like

cargo test -p datafusion --test sql_integration

Additional context
I think this came in via #1491

@github-actions github-actions bot added the datafusion Changes in the datafusion crate label Jan 15, 2022
Copy link
Member

@xudong963 xudong963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to me. I was used to cargo test directly, so I didn't notice this problem.

@alamb alamb merged commit 1dae7e2 into apache:master Jan 16, 2022
@alamb alamb deleted the alamb/rename_sql_test branch August 8, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQL integration tests named mod
3 participants