support decimal data type in create table #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
datafusion
houqp
approved these changes
Dec 10, 2021
Dandandan
reviewed
Dec 10, 2021
datafusion/src/sql/planner.rs
Outdated
| // TODO add bound checker in some utils file or function | ||
| if *p > 38 || *s > *p { | ||
| return Err(DataFusionError::Internal(format!( | ||
| "Error Decimal Type ({:?})", |
There was a problem hiding this comment.
A slightly more informative error would be better, such as "precision above 38 / scale bigger than precision" not supported.
There was a problem hiding this comment.
Thanks for your suggestion.
It has been modified.
Dandandan
reviewed
Dec 10, 2021
| // TODO add bound checker in some utils file or function | ||
| if *p > 38 || *s > *p { | ||
| return Err(DataFusionError::Internal(format!( | ||
| "Error Decimal Type ({:?})", |
Dandandan
reviewed
Dec 10, 2021
datafusion/tests/sql.rs
Outdated
| async fn register_simple_aggregate_csv_with_decimal_by_sql(ctx: &mut ExecutionContext) { | ||
| let df = ctx | ||
| .sql( | ||
| " CREATE EXTERNAL TABLE aggregate_simple ( |
There was a problem hiding this comment.
Suggested change
| " CREATE EXTERNAL TABLE aggregate_simple ( | |
| "CREATE EXTERNAL TABLE aggregate_simple ( |
|
PTAL @Dandandan again. |
Dandandan
approved these changes
Dec 11, 2021
|
@alamb please merge this. |
|
Thanks @liukun4515 |
|
🎉 Thank you very much @liukun4515 , @Dandandan and @houqp |
alamb
reviewed
Dec 12, 2021
| ))); | ||
| } | ||
| (Some(p), Some(s)) => { | ||
| // TODO add bound checker in some utils file or function |
| #[tokio::test] | ||
| async fn csv_query_with_decimal_by_sql() -> Result<()> { | ||
| let mut ctx = ExecutionContext::new(); | ||
| register_simple_aggregate_csv_with_decimal_by_sql(&mut ctx).await; |
mcheshkov
pushed a commit
to cube-js/arrow-datafusion
that referenced
this pull request
Aug 23, 2024
…create table (apache#1431)" * support decimal data type in create table Can drop this after rebase on commit dc80c11, first released in 7.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
related #122
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?