Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visibility of swap_hash_join to be pub #13899

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Dec 24, 2024

Which issue does this PR close?

Rationale for this change

swap_hash_join used to be pub and now it is pub(crate) which means other downstream crates can't use it

What changes are included in this PR?

Restore swap_hash_join to be pub

Are these changes tested?

Are there any user-facing changes?

@alamb alamb requested a review from berkaysynnada December 24, 2024 21:23
@github-actions github-actions bot added the core Core DataFusion crate label Dec 24, 2024
@alamb alamb changed the title Fix visibility of swap_hash_join Fix visibility of swap_hash_join to be pub Dec 24, 2024
@alamb alamb mentioned this pull request Dec 24, 2024
10 tasks
@alamb
Copy link
Contributor Author

alamb commented Dec 24, 2024

Thanks for the review @Omega359 -- this PR now needs another commiter to approve before i can merge it 😭
Screenshot 2024-12-24 at 5 01 05 PM

@andygrove andygrove merged commit 3864b11 into apache:main Dec 24, 2024
25 checks passed
@alamb alamb deleted the alamb/fix_visibility branch December 24, 2024 22:19
@alamb
Copy link
Contributor Author

alamb commented Dec 24, 2024

Thanks @andygrove 🙏

@ozankabak
Copy link
Contributor

Thanks for the fast fix @alamb and sorry for the inconvenience

@berkaysynnada
Copy link
Contributor

berkaysynnada commented Dec 25, 2024

Sorry for the inconvenience, I probably tried to set the all functions at the same visibility.

@alamb
Copy link
Contributor Author

alamb commented Dec 25, 2024

Sorry for the inconvenience, I probably tried to set the all functions at the same visibility.

No worries - it was easily fixed. Thanks for driving things forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

swap_hash_join is no longer public so comet doesn't compile
5 participants