Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Add debug log message for creating GroupValuesRows #13506

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Minor: Add debug log message for creating GroupValuesRows #13506

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
654619c
Minor: Add debug log message for creating GroupValuesRows
alamb Nov 20, 2024
0e5e04d
fmt
alamb Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions datafusion/physical-plan/src/aggregates/group_values/row.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ use datafusion_common::Result;
use datafusion_execution::memory_pool::proxy::{RawTableAllocExt, VecAllocExt};
use datafusion_expr::EmitTo;
use hashbrown::raw::RawTable;
use log::debug;
use std::mem::size_of;
use std::sync::Arc;

Expand Down Expand Up @@ -80,6 +81,9 @@ pub struct GroupValuesRows {

impl GroupValuesRows {
pub fn try_new(schema: SchemaRef) -> Result<Self> {
// Print a debugging message, so it is clear when the (slower) fallback
// GroupValuesRows is used.
debug!("Creating GroupValuesRows for schema: {}", schema);
let row_converter = RowConverter::new(
schema
.fields()
Expand Down