Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unparse struct to sql #13493
Unparse struct to sql #13493
Changes from 7 commits
626e2dd
378679e
4e83eb3
bd4d71d
6222885
ef4209a
9c3ba00
a8dd310
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should consider the more complex cases, a struct contains a struct field. Consider the following SQL that uses another way to access the struct:
You can see the
get_field
accepts anotherget_field
function. However, I think we can't do a roundtrip test for this kind of case currently because SQL likeselect s.a.a1
isn't supported (apache/datafusion-sqlparser-rs#1541 will address it).By the way, I think we can file a follow-up issue for the nested case. We don't need to support it in this PR.