Minor: improve LogicalPlanBuilder::join_with_expr_keys docs
#13276
+13
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanc-n
reviewed
Nov 6, 2024
Co-authored-by: Jonathan Chen <[email protected]>
github-actions
bot
removed
the
documentation
comphead
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #13182
Rationale for this change
While reviewing #13182 from @onursatici it was not immediatley clear to @gruuya #13182 (comment) and myself that the expressions were constrained to the left and right input
What changes are included in this PR?
LogicalPlanBuilder::join_with_expr_keysto make this clearerAre these changes tested?
CI
Are there any user-facing changes?
Docs only