Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: re-export functions_window_common::ExpressionArgs #13149

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

Michael-J-Ward
Copy link
Contributor

Which issue does this PR close?

Closes #13148.

Rationale for this change

ExpressionArgs is needed to implement WindowUDFImpl as of #12857, but it is not currently re-exported.

What changes are included in this PR?

ExpressionArgs is re-exported in datafusion_expr::function.

I placed it here because that is where WindowUDFFieldArgs and PartitionEvaluatorArgs are re-exported.

Are these changes tested?

N/A

Are there any user-facing changes?

Not from any released version

This struct is needed to implement the WindowUDFImpl trait.
@github-actions github-actions bot added the logical-expr Logical plan and expressions label Oct 29, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@alamb alamb merged commit b30d12a into apache:main Oct 29, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logical-expr Logical plan and expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

re-export ExpressionArgs
2 participants