Add more functions for string sqllogictests #12665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldmedal
force-pushed
the
chore/12415-add-string-function-test
branch
from
fc07a69
to
9a79ae9
Compare
alamb
reviewed
Sep 29, 2024
| @@ -37,6 +37,52 @@ select arrow_cast(col1, 'Dictionary(Int32, Utf8)') as c1 from test_substr_base; | |||
| statement ok | |||
| drop table test_source | |||
|
|
|||
| # TODO: move it back to `string_query.slt.part` after fixing the issue | |||
There was a problem hiding this comment.
This experience moving tests has found many great bugs. Thank you @goldmedal for finding and filing them
alamb
approved these changes
Sep 30, 2024
| REVERSE(unicode_1) | ||
| FROM test_basic_operator; | ||
| ---- | ||
| werdnA 🔥📊noisufatad |
There was a problem hiding this comment.
Werdna -- this brings back memories from my childhood when sometimes kids would refer to my name like this.
|
Thanks @alamb ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #12415
Rationale for this change
Finished the todo list at #12415 (comment)
What changes are included in this PR?
function.slttostring/string_literal.slt.Are these changes tested?
yes
Are there any user-facing changes?
no