Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SUBSTR scalar function to support Utf8View #12019

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

demetribu
Copy link
Contributor

Which issue does this PR close?

Closes #11952.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added sqllogictest SQL Logic Tests (.slt) functions labels Aug 15, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you @dmitrybugakov 🙏

I also filed #12031 to track an additional improvement of creating StringView as output of this function.

@alamb alamb merged commit 300a08c into apache:main Aug 16, 2024
24 checks passed
@demetribu demetribu deleted the update-substr-utf8view branch October 5, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
functions sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update SUBSTR scalar function to support Utf8View
2 participants