Improve lpad udf by using a GenericStringBuilder #11987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure/lpad_utf8view
alamb
approved these changes
Aug 14, 2024
| group.bench_function(BenchmarkId::new("largeutf8 type", size), |b| { | ||
| b.iter(|| criterion::black_box(rpad().invoke(&args).unwrap())) | ||
| }); | ||
| // |
There was a problem hiding this comment.
any reason to leave this commented out?
There was a problem hiding this comment.
rpad update with utf8view wasn't committed yet. I know it would work anyways but I think now that rpad update is committed it's good to uncomment.
There was a problem hiding this comment.
Maybe we can make a follow on PR with cleaning up rpad and applying the same pattern. I filed #11997 to track that idea
| return exec_err!("lpad requested length {length} too large"); | ||
| } | ||
| let array = if fill_array.is_none() { | ||
| let mut builder: GenericStringBuilder<T> = GenericStringBuilder::new(); |
This was referenced Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11984
Rationale for this change
Code cleanup, performance improvement.
What changes are included in this PR?
Code, benchmark.
Are these changes tested?
Yes
Are there any user-facing changes?
No