Implement native support StringView for REPEAT
#11962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tai Le Manh <[email protected]>
tlm365
force-pushed
the
utf8view-repeat
branch
from
1f76b9c
to
2cdf18b
Compare
22 tasks
alamb
approved these changes
Aug 13, 2024
| Ok(Arc::new(result) as ArrayRef) | ||
| } | ||
|
|
||
| fn repeat_common(string: Option<&str>, number: Option<i64>) -> Option<String> { |
There was a problem hiding this comment.
I think you could make this perform much better by avoiding the String and instead building the output directly with StringViewBuilder
https://docs.rs/arrow/latest/arrow/array/type.StringViewBuilder.html
here is an example of how to use them: apache/arrow-rs#6240
I realize this just follows the same model as was here. However, if we are messing with the code it might be nice to make it faster while we are at it
There was a problem hiding this comment.
@alamb thanks so much for reviewing. I will take a look!
There was a problem hiding this comment.
Thank you -- I filed #11990 to track the idea
|
I took the liberty of merging up from main and running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11914 and part of #11790.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?