Rename Expr::display_name to Expr::schema_name, make UNNEST naming conform to convention

datafusion/core/src/physical_planner.rs

@@ -213,7 +213,7 @@ fn create_physical_name(e: &Expr, is_first_expr: bool) -> Result<String> {
             let expr = create_physical_name(expr, false)?;
             Ok(format!("{expr} IS NOT UNKNOWN"))
         }
-        Expr::ScalarFunction(fun) => fun.func.display_name(&fun.args),
+        Expr::ScalarFunction(fun) => fun.func.schema_name(&fun.args),
         Expr::WindowFunction(WindowFunction {
             fun,
             args,
@@ -1794,7 +1794,7 @@ pub fn create_window_expr(
     // unpack aliased logical expressions, e.g. "sum(col) over () as total"
     let (name, e) = match e {
         Expr::Alias(Alias { expr, name, .. }) => (name.clone(), expr.as_ref()),
-        _ => (e.display_name()?, e),
+        _ => (e.schema_name()?, e),
     };
     create_window_expr_with_name(e, name, logical_schema, execution_props)
 }
@@ -1887,7 +1887,7 @@ pub fn create_aggregate_expr_and_maybe_filter(
     // unpack (nested) aliased logical expressions, e.g. "sum(col) as total"
     let (name, e) = match e {
         Expr::Alias(Alias { expr, name, .. }) => (name.clone(), expr.as_ref()),
-        Expr::AggregateFunction(_) => (e.display_name().unwrap_or(physical_name(e)?), e),
+        Expr::AggregateFunction(_) => (e.schema_name().unwrap_or(physical_name(e)?), e),
         _ => (physical_name(e)?, e),
     };