Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to_local_time() in function reference docs #11401

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

appletreeisyellow
Copy link
Contributor

@appletreeisyellow appletreeisyellow commented Jul 10, 2024

Which issue does this PR close?

Follow-up PR for #11347 (comment)

Relates to #10602, #11358

Rationale for this change

A scalar UDF to_local_time() was added in #11347. This PR documents to_local_time() in the scalar function reference page.

What changes are included in this PR?

After adding the document for to_local_time(), the doc page will look like this:

Screenshot 2024-07-10 at 2 51 54 PM

Are these changes tested?

No. Only adding documents, so it shouldn't break anything.

Are there any user-facing changes?

No

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great -- thank you @appletreeisyellow

docs/source/user-guide/sql/scalar_functions.md Outdated Show resolved Hide resolved
docs/source/user-guide/sql/scalar_functions.md Outdated Show resolved Hide resolved
@alamb alamb changed the title Add to_local_time() in document Add to_local_time() in function reference Jul 10, 2024
@alamb alamb added the documentation Improvements or additions to documentation label Jul 10, 2024
@alamb
Copy link
Contributor

alamb commented Jul 10, 2024

cc @Abdullahsab3

Co-authored-by: Andrew Lamb <[email protected]>
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Jul 10, 2024
@alamb alamb changed the title Add to_local_time() in function reference Add to_local_time() in function reference docs Jul 11, 2024
@alamb alamb added the documentation Improvements or additions to documentation label Jul 11, 2024
@alamb alamb merged commit e19dd2d into apache:main Jul 11, 2024
6 checks passed
@alamb
Copy link
Contributor

alamb commented Jul 11, 2024

Thanks again @appletreeisyellow !

@appletreeisyellow appletreeisyellow deleted the chunchun/to-local-time-doc branch July 11, 2024 17:59
Lordworms pushed a commit to Lordworms/arrow-datafusion that referenced this pull request Jul 12, 2024
* chore: add document for `to_local_time()`

* chore: feedback

Co-authored-by: Andrew Lamb <[email protected]>

---------

Co-authored-by: Andrew Lamb <[email protected]>
findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
* chore: add document for `to_local_time()`

* chore: feedback

Co-authored-by: Andrew Lamb <[email protected]>

---------

Co-authored-by: Andrew Lamb <[email protected]>
xinlifoobar pushed a commit to xinlifoobar/datafusion that referenced this pull request Jul 17, 2024
* chore: add document for `to_local_time()`

* chore: feedback

Co-authored-by: Andrew Lamb <[email protected]>

---------

Co-authored-by: Andrew Lamb <[email protected]>
xinlifoobar pushed a commit to xinlifoobar/datafusion that referenced this pull request Jul 18, 2024
* chore: add document for `to_local_time()`

* chore: feedback

Co-authored-by: Andrew Lamb <[email protected]>

---------

Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants