Minor: some cosmetics in filter.rs, fix clippy due to logical conflict
#11368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jul 9, 2024
| @@ -91,14 +88,14 @@ impl FilterExec { | |||
|
|
|||
| Ok(Self { | |||
| predicate, | |||
| input: input.clone(), | |||
| input: Arc::clone(&input), | |||
There was a problem hiding this comment.
This was causing clippy failures on main https://github.com/apache/datafusion/actions/runs/9857745125/job/27217695529
I think due to a logical conflict
| Err(_) => { | ||
| let Ok(null_array) = as_null_array(&array) else { | ||
| return internal_err!("Cannot create filter_array from non-boolean predicates, unable to continute"); | ||
| return internal_err!( |
alamb
changed the title
filter.rsfilter.rs, fix clippy due to logical conflict
|
Merging this one in to get the fix for clippy |
This was referenced Jul 9, 2024
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
…ict (apache#11368) * Minor: some cosmetics in `filter.rs` * Minor: some cosmetics in `filter.rs`
xinlifoobar
pushed a commit
to xinlifoobar/datafusion
that referenced
this pull request
Jul 18, 2024
…ict (apache#11368) * Minor: some cosmetics in `filter.rs` * Minor: some cosmetics in `filter.rs`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?