Minor: reduce replication for nested comparison #11149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Jun 27, 2024
| let values = (0..len).map(|i| cmp(i, i).is_eq()).collect(); | ||
| let nulls = NullBuffer::union(left.nulls(), right.nulls()); | ||
| return Ok(BooleanArray::new(values, nulls)); | ||
| return Ok(compare_op_for_nested(&Operator::Eq, &left, &right)?); |
There was a problem hiding this comment.
the point of the PR is to use the pre-existing function that already handles this
There was a problem hiding this comment.
I think we can use apply_cmp_for_nested and keep compare_op_for_nested private here.
There was a problem hiding this comment.
The reason I used compare_op_for_nested was that apply_cmp_for_nested returns a ColumnarValue and this function has to &dyn Arrays
rtyler
approved these changes
Jun 27, 2024
jayzhan211
approved these changes
Jun 28, 2024
|
Thank you @rtyler and @jayzhan211 for the reviews |
comphead
pushed a commit
to comphead/arrow-datafusion
that referenced
this pull request
Jul 2, 2024
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #11117
Rationale for this change
@jayzhan211 had a suggestion on how to simplify the implementation in #11117 (comment) from @rtyler .
What changes are included in this PR?
Use a pre-existing function to compare structured types
Are these changes tested?
Covered by existing tests (added in #11117)
Are there any user-facing changes?