-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support to unparse IntervalYearMonth and IntervalDayTime to String #11065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
SQL Planner
logical-expr
Logical plan and expressions
labels
Jun 22, 2024
goldmedal
changed the title
Support to unparse IntervalYearMonth and IntervalDayTime to string
Support to unparse IntervalYearMonth and IntervalDayTime to String
Jun 22, 2024
alamb
approved these changes
Jun 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @goldmedal -- this looks great to me
r#"INTERVAL '1 YEARS 1 MONS 0 DAYS 0 HOURS 0 MINS 0.00 SECS'"#, | ||
), | ||
( | ||
interval_year_month_lit("1.5 YEAR 1 MONTH"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks @alamb :) |
xinlifoobar
pushed a commit
to xinlifoobar/datafusion
that referenced
this pull request
Jun 22, 2024
xinlifoobar
pushed a commit
to xinlifoobar/datafusion
that referenced
this pull request
Jun 22, 2024
y-f-u
pushed a commit
to spiceai/datafusion
that referenced
this pull request
Jun 24, 2024
y-f-u
pushed a commit
to spiceai/datafusion
that referenced
this pull request
Jun 24, 2024
y-f-u
added a commit
to spiceai/datafusion
that referenced
this pull request
Jun 24, 2024
support to unparse interval to string (apache#11065)
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
It's a follow up of #10795 and a part of #9494
Rationale for this change
What changes are included in this PR?
Are these changes tested?
yes
Are there any user-facing changes?
no