fix: Support double quotes in date_part
#10833
Conversation
| @@ -127,7 +127,7 @@ impl ScalarUDFImpl for DatePartFunc { | |||
| ColumnarValue::Scalar(scalar) => scalar.to_array()?, | |||
| }; | |||
|
|
|||
| let arr = match part.to_lowercase().as_str() { | |||
| let arr = match part.to_lowercase().trim_matches('\'').trim_matches('"') { | |||
There was a problem hiding this comment.
TIL https://doc.rust-lang.org/std/primitive.str.html#method.trim_matches -- perfect 👍
Weijun-H
changed the title
Weijun-H
changed the title
date_part
| @@ -127,7 +127,7 @@ impl ScalarUDFImpl for DatePartFunc { | |||
| ColumnarValue::Scalar(scalar) => scalar.to_array()?, | |||
| }; | |||
|
|
|||
| let arr = match part.to_lowercase().as_str() { | |||
| let arr = match part.to_lowercase().trim_matches('\'').trim_matches('"') { | |||
There was a problem hiding this comment.
TIL https://doc.rust-lang.org/std/primitive.str.html#method.trim_matches -- perfect 👍
Weijun-H
force-pushed
the
support-double-quota
branch
from
9de8175
to
9606336
Compare
It seems the invalid input @Jefffrey DataFusion CLI v39.0.0
> select extract('''epoch''' from now()); 🤔 Invalid statement: sql parser error: Expected date/time field, found: ''epoch'' |
Ah whoops. What about: select extract("''''epoch''''" from now());FWIW this is how Postgres treats it: |
Weijun-H
force-pushed
the
support-double-quota
branch
from
6df48a4
to
9043875
Compare
| let arr = match part | ||
| .to_lowercase() | ||
| .replacen('\'', "", 2) | ||
| .replacen('\"', "", 2) | ||
| .as_str() |
There was a problem hiding this comment.
Hmm, this will still let select extract("'epoch'" from now()); through
But this is quite a minor thing, not sure how much it matters in the wider picture 😅
There was a problem hiding this comment.
I found a workaround, but it should be a better way to handle it in sqlparser. Because it should have many use cases.
* fix: Support double quotes in date_part.rs * chore * chore * refacor: Use Regex to extract * chore * chore: Use replaceen * chore * fix
Which issue does this PR close?
Parts #10826
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?