Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Move aggregate variance to slt #10750

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

marvinlanhenke
Copy link
Contributor

@marvinlanhenke marvinlanhenke commented Jun 1, 2024

Which issue does this PR close?

Close #10384

Rationale for this change

What changes are included in this PR?

  • moved tests to aggregate.slt

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added physical-expr Physical Expressions sqllogictest SQL Logic Tests (.slt) labels Jun 1, 2024
@marvinlanhenke
Copy link
Contributor Author

@jayzhan211 PTAL. Also I think this was the last one? perhaps #10384 can be closed then?

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you @marvinlanhenke

Copy link
Contributor

@jayzhan211 jayzhan211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jayzhan211
Copy link
Contributor

@jayzhan211 PTAL. Also I think this was the last one? perhaps #10384 can be closed then?

Yes, it seems like the last one

@jayzhan211 jayzhan211 merged commit 1db3263 into apache:main Jun 2, 2024
24 checks passed
@jayzhan211
Copy link
Contributor

Thanks @marvinlanhenke @alamb

findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
physical-expr Physical Expressions sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port aggregate test to sqllogictest
3 participants