-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor: improve Expr documentation #10685
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
SQL Planner
logical-expr
Logical plan and expressions
and removed
documentation
Improvements or additions to documentation
labels
May 27, 2024
alamb
force-pushed
the
alamb/expr_docs
branch
2 times, most recently
from
May 27, 2024 10:21
2ec8f11
to
a0811d8
Compare
comphead
reviewed
May 28, 2024
comphead
approved these changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks @alamb
github-actions
bot
removed
the
documentation
Improvements or additions to documentation
label
May 29, 2024
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* Minor: improve Expr documentation * Update datafusion/expr/src/expr.rs Co-authored-by: Oleks V <[email protected]> * Refine words --------- Co-authored-by: Oleks V <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #7013
Rationale for this change
I was preparing to add some examples of TreeNode APIs and I noticed several places to improve
Expr
APIsWhat changes are included in this PR?
Improve docstrings and examples
Are these changes tested?
By CI
Are there any user-facing changes?
Only doc changes, no functional changes