Add tests for reading numeric limits in parquet statistics #10642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
force-pushed
the
alamb/numeric_limits_tests
branch
from
de935ed
to
efcb93d
Compare
comphead
reviewed
May 24, 2024
comphead
reviewed
May 24, 2024
comphead
approved these changes
May 24, 2024
Co-authored-by: Oleks V <[email protected]>
…ion into alamb/numeric_limits_tests
|
Thanks again for the review @comphead |
9 tasks
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
) * Add numeric limits tests for statistics reading * Apply suggestions from code review Co-authored-by: Oleks V <[email protected]> * fix --------- Co-authored-by: Oleks V <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #10453
Rationale for this change
As we fill out parquet statistics features, it would be good to ensure they work well with numeric limits (aka the ranges of values of different types)
What changes are included in this PR?
Add new tests for numeric limits
Are these changes tested?
Only tests
Are there any user-facing changes?
No