Clean up parquet_index example #10618
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
force-pushed
the
alamb/external_parquet_index_cleanup
branch
from
591dd6c
to
a10f1fb
Compare
This was referenced May 23, 2024
alamb
force-pushed
the
alamb/external_parquet_index_cleanup
branch
from
fb92109
to
c650bdf
Compare
alamb
force-pushed
the
alamb/external_parquet_index_cleanup
branch
from
c650bdf
to
5b112a1
Compare
alamb
force-pushed
the
alamb/external_parquet_index_cleanup
branch
from
5b112a1
to
1a4655e
Compare
|
These changes are now all included in #10549, so closing this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #10549
Rationale for this change
When creating the example in #10549 I noticed a few APIs that were akward to use. Thus I am working on making PRs to improve them:
FileScanConfig::new(): AddFileScanConfig::new()API #10623ParquetExecBuilder: AddParquetExec::builder(), deprecateParquetExec::new#10636This PR shows how they will simplify the example of creating external indexes
What changes are included in this PR?
Update
parquet_index.rsexample to use simpler APIsAre these changes tested?
Covered by CI
Are there any user-facing changes?