Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop copying LogicalPlan and Exprs in SingleDistinctToGroupBy #10527

Merged
merged 8 commits into from
May 22, 2024
Merged

Stop copying LogicalPlan and Exprs in SingleDistinctToGroupBy #10527

merged 8 commits into from
May 22, 2024

Commits on May 14, 2024

  1. chore: merge main and resolve conflict

    @appletreeisyellow
    appletreeisyellow committed May 14, 2024
    Configuration menu
    Copy the full SHA
    3bea893 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. chore: use less copy

    @appletreeisyellow
    appletreeisyellow committed May 15, 2024
    Configuration menu
    Copy the full SHA
    b2609d5 View commit details
    Browse the repository at this point in the history

  2. chore: remove clone

    @appletreeisyellow
    appletreeisyellow committed May 15, 2024
    Configuration menu
    Copy the full SHA
    4b322f2 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. remove more clones (#8) 

    * refactor: use HashSet<&Expr> instead of HashSet<String>

* refactor: remove more cloning
    @erratic-pattern
    erratic-pattern authored May 17, 2024
    Configuration menu
    Copy the full SHA
    c02a63a View commit details
    Browse the repository at this point in the history

  2. chore: merge main and resolve conflict

    @appletreeisyellow
    appletreeisyellow committed May 17, 2024
    Configuration menu
    Copy the full SHA
    0ba579c View commit details
    Browse the repository at this point in the history

  3. chore: reduce string allocation 

    Co-authored-by: Adam Curtis <[email protected]>
    @appletreeisyellow @erratic-pattern
    appletreeisyellow and erratic-pattern committed May 17, 2024
    Configuration menu
    Copy the full SHA
    0f069b4 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. chore: return internal error instead of panacing

    @appletreeisyellow
    appletreeisyellow committed May 20, 2024
    Configuration menu
    Copy the full SHA
    55e3d16 View commit details
    Browse the repository at this point in the history

  2. chore: use arg display_name as hash key instead of a hashed value

    @appletreeisyellow
    appletreeisyellow committed May 20, 2024
    Configuration menu
    Copy the full SHA
    2ba102f View commit details
    Browse the repository at this point in the history