Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify docs explaining the relationship between SessionState and SessionContext #10350

Merged
merged 2 commits into from
May 3, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented May 2, 2024

Which issue does this PR close?

Part of #7013

Rationale for this change

As @westonpace explained in #10330 (comment) the relationship and differences between these classes is not clear.

What changes are included in this PR?

Try to clarify the differences and when people should create one or the other

Are these changes tested?

CI doc checks

Are there any user-facing changes?

Just docs, no change in functionality

@alamb alamb added the documentation Improvements or additions to documentation label May 2, 2024
@github-actions github-actions bot added core Core DataFusion crate and removed documentation Improvements or additions to documentation labels May 2, 2024
@alamb
Copy link
Contributor Author

alamb commented May 2, 2024

CI failed due to #10352

Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this helps my understanding a lot!

@alamb alamb added the documentation Improvements or additions to documentation label May 3, 2024
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @alamb lgtm

@comphead comphead merged commit 2c56a3c into apache:main May 3, 2024
23 checks passed
@alamb alamb deleted the alamb/session_state_docs branch May 3, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants