Rewrite CommonSubexprEliminate
to avoid copies using TreeNode
#10067
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP -- still has many more copies to remove
Which issue does this PR close?
Part of #9637
related to #9873
Rationale for this change
Let's make planning faster by not copying so much in the optimizer using the new TreeNode API.
What changes are included in this PR?
Note this pass still leaves a lot to be desired in terms of copying Exprs / making strings but it is much better now. Fixing up the additional copies is tracked with #9873
Are these changes tested?
Functional: existing tests
Performance: TBD
Are there any user-facing changes?