Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port tests in expr.rs to sqllogictest #8201

Closed
Tracked by #6195
alamb opened this issue Nov 15, 2023 · 6 comments · Fixed by #9014
Closed
Tracked by #6195

Port tests in expr.rs to sqllogictest #8201

alamb opened this issue Nov 15, 2023 · 6 comments · Fixed by #9014
Labels
good first issue Good for newcomers

Comments

@alamb
Copy link
Contributor

alamb commented Nov 15, 2023

Is your feature request related to a problem or challenge?

Part of #6195. We are trying to

  1. keep the DataFusion code base clean and easy to contribute to and modify
  2. Understand what features are covered and what are not

Part of doing so is having a single location for most test coverage so new tests can be added easily and people can follow the existing patterns easily

Describe the solution you'd like

Port the tests in https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/sql/expr.rs to
expr.slt in https://github.com/apache/arrow-datafusion/tree/main/datafusion/sqllogictest/test_files

Note you can create catalogs and schema via SQL now

Catalogs: https://arrow.apache.org/datafusion/user-guide/sql/ddl.html#create-database
Schema: https://arrow.apache.org/datafusion/user-guide/sql/ddl.html#create-schema

Notes:

  1. Instructions for running sqllogitest are here: https://github.com/apache/arrow-datafusion/tree/main/datafusion/sqllogictest

Describe alternatives you've considered

No response

Additional context

I think these are good first issues as they teach the contributor about the DataFusion codebase and tests, as well as see the end user apis in practice.

@comphead
Copy link
Contributor

comphead commented Jan 5, 2024

Picking it, was working on another feature and started to move tests in expr.rs

@alamb
Copy link
Contributor Author

alamb commented Jan 25, 2024

There are not that many tests left in expr.rs -- this would still be a good first issue for someone to finish off

@Tangruilin
Copy link
Contributor

@alamb , I can help with the left tests

@Tangruilin
Copy link
Contributor

You can assigned it to me

@alamb
Copy link
Contributor Author

alamb commented Jan 26, 2024

Thanks @Tangruilin

@alamb
Copy link
Contributor Author

alamb commented Jan 26, 2024

Wow -- this is the last item left on the list of #6195 -- we are so close!

Tangruilin added a commit to Tangruilin/arrow-datafusion that referenced this issue Jan 27, 2024
alamb added a commit that referenced this issue Jan 28, 2024
#9014)

* [task #8201] Port tests in expr.rs to sqllogictest, finish the left cases

Signed-off-by: tangruilin <[email protected]>

* Apply suggestions from code review

* Add a few more comments

---------

Signed-off-by: tangruilin <[email protected]>
Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants