Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unlimited memory consumption in RepartitionExec #4816

Closed
Tracked by #587
crepererum opened this issue Jan 4, 2023 · 1 comment · Fixed by #4820
Closed
Tracked by #587

Unlimited memory consumption in RepartitionExec #4816

crepererum opened this issue Jan 4, 2023 · 1 comment · Fixed by #4820
Labels
bug Something isn't working

Comments

@crepererum
Copy link
Contributor

Describe the bug
See https://github.com/apache/arrow-datafusion/blob/5b70e3543f5c10832e43ed25e7d4166cf0c1df78/datafusion/core/src/physical_plan/repartition.rs#L333-L340

To Reproduce
-

Expected behavior
The data kept in these channels should be registered with the MemoryManager.

Additional context
-
@crepererum crepererum added the bug Something isn't working label Jan 4, 2023
@crepererum
Copy link
Contributor Author

I'm working on this.

crepererum added a commit to crepererum/arrow-datafusion that referenced this issue Jan 4, 2023
@crepererum
fix: account for memory in RepartitionExec
3ee4902 
Fixes apache#4816.
@crepererum crepererum mentioned this issue Jan 4, 2023
Merged
alamb pushed a commit that referenced this issue Jan 7, 2023
@crepererum
fix: account for memory in RepartitionExec (#4820)
83c1026 
* refactor: explicit loop instead of (tail) recursion

* test: simplify

* fix: account for memory in `RepartitionExec`

Fixes #4816.

* fix: sorting memory limit test
@alamb alamb mentioned this issue Mar 5, 2023
Closed
8 tasks
@milenkovicm milenkovicm mentioned this issue Oct 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: account for memory in RepartitionExec crepererum/arrow-datafusion
1 participant
@crepererum