Deprecate PhysicalSortRequirement::from_sort_exprs and PhysicalSortRequirement::to_sort_exprs
#13222
+61
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
…tRequirement::to_sort_exprs`
alamb
force-pushed
the
alamb/deprecate_conversions
branch
from
50ded20
to
79278f8
Compare
alamb
commented
Nov 1, 2024
| vec![Some(PhysicalSortRequirement::from_sort_exprs( | ||
| self.expr.iter(), | ||
| ))] | ||
| vec![Some(LexRequirement::from(self.expr.clone()))] |
There was a problem hiding this comment.
This is a pretty good example of the potential improvement -- it is now clear this function is returning a LexRequirement and that it clones the underlying LexOrdering structure
This was still happening on main but the conversion was hidden
alamb
commented
Nov 1, 2024
| @@ -243,8 +240,7 @@ fn pushdown_requirement_to_children( | |||
| smj.schema().fields.len() - smj.right().schema().fields.len(); | |||
| let new_right_required = | |||
| shift_right_required(parent_required, right_offset)?; | |||
| let new_right_required_expr = | |||
| PhysicalSortRequirement::to_sort_exprs(new_right_required); | |||
| let new_right_required_expr = LexOrdering::from(new_right_required); | |||
There was a problem hiding this comment.
I think this structure makes it much clearer what is going on
alamb
commented
Nov 5, 2024
| @@ -221,7 +221,7 @@ fn replace_with_partial_sort( | |||
| // here we're trying to find the common prefix for sorted columns that is required for the | |||
| // sort and already satisfied by the given ordering | |||
| let child_eq_properties = child.equivalence_properties(); | |||
| let sort_req = PhysicalSortRequirement::from_sort_exprs(sort_plan.expr()); | |||
| let sort_req = LexRequirement::from(sort_plan.expr().clone()); | |||
There was a problem hiding this comment.
Again, there is no more cloning going on than previously, just now the clone is explicit
berkaysynnada
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Looks great, the code is clearly improving. Thank you @alamb.
|
Thank you for the review @berkaysynnada |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #12591
Rationale for this change
Before
LexOrderingandLexRequirementwere actual structs (thanks to @ngli-me and @berkaysynnada on #13146!!!), we couldn't put the conversion betweenLexOrderingandLexRequirementon to the actual structures and thus the conversion is done via free functions onPhysicalSortRequirementsThis is confusing for several reasons:
Fromconversion they aren't there)This structure bothered me for a long time, so it is time to scratch an itch now that @ngli-me started the ball rolling
What changes are included in this PR?
PhysicalSortRequirement::from_sort_exprsandPhysicalSortRequirement::to_sort_exprsLexOrdering::from_lex_requirementandLexOrdering::from_lex_orderingandFromimplsAre these changes tested?
By existint CI
Are there any user-facing changes?
SOme methods are deprecated with hints about what to use instead