Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making LexOrderingRef an actual struct #12591

Closed
ngli-me opened this issue Sep 23, 2024 · 1 comment · Fixed by #13146
Closed

Making LexOrderingRef an actual struct #12591

ngli-me opened this issue Sep 23, 2024 · 1 comment · Fixed by #13146
Assignees
@ngli-me
Labels
enhancement New feature or request

Comments

@ngli-me
Copy link
Contributor

ngli-me commented Sep 23, 2024

Is your feature request related to a problem or challenge?

Perhaps we could follow a similar pattern for LexOrderingRef, too.

Originally posted by @berkaysynnada in #12583 (comment)

Describe the solution you'd like

Wrap LexOrderingRef in a struct, similar to how LexRequirement is being changed.

Describe alternatives you've considered

No response

Additional context

See Issue #12255, and PR #12583.
@ngli-me ngli-me added the enhancement New feature or request label Sep 23, 2024
@ngli-me ngli-me mentioned this issue Sep 23, 2024
Merged
@ngli-me
Copy link
Contributor Author

ngli-me commented Oct 24, 2024

take

@ngli-me ngli-me changed the title Making LexOrderingRequest an actual struct Making LexOrderingRef an actual struct Oct 24, 2024
@ngli-me ngli-me mentioned this issue Oct 28, 2024
Merged
This was referenced Nov 1, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ngli-me ngli-me

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert LexOrdering type to struct. ngli-me/datafusion
1 participant
@ngli-me