You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Now that LexOrdering and LexRequirement are actual structs thanks to @ngli-me and @berkaysynnada on #13146, we can refer to their references as &LexOrdering and &LexRequirement directly rather than going through a type alias.
For example
///`LexOrderingRef` is an alias for the type &`[PhysicalSortExpr]`, which represents/// a reference to a lexicographical ordering.pubtypeLexOrderingRef<'a> = &'a [PhysicalSortExpr];
This is significantly less confusing than the current situation where we have both &LexOrdering and LexOrderingRef and &LexRequirement and LexRequirementRef
Describe the solution you'd like
I would like to
Deprecate LexOrderingRef and LexRequirementRef
Update all references to use &LexOrdering and &LexRequirement directly
Describe alternatives you've considered
Basically make this change:
///`LexOrderingRef` is an alias for the type &`[PhysicalSortExpr]`, which represents/// a reference to a lexicographical ordering.#[deprecated(since = "43.0.0", note = "use &LexOrdering instead")]pubtypeLexOrderingRef<'a> = &'a [PhysicalSortExpr];
And the similar change to LexRequirementRef and then fix all the clippy errors :)
Additional context
I have a WIP here #13205 that someone could pull from
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem or challenge?
Follow on to #12591
Now that
LexOrdering
andLexRequirement
are actual structs thanks to @ngli-me and @berkaysynnada on #13146, we can refer to their references as&LexOrdering
and&LexRequirement
directly rather than going through a type alias.For example
This is significantly less confusing than the current situation where we have both
&LexOrdering
andLexOrderingRef
and&LexRequirement
andLexRequirementRef
Describe the solution you'd like
I would like to
LexOrderingRef
andLexRequirementRef
&LexOrdering
and&LexRequirement
directlyDescribe alternatives you've considered
Basically make this change:
And the similar change to
LexRequirementRef
and then fix all the clippy errors :)Additional context
I have a WIP here #13205 that someone could pull from
The text was updated successfully, but these errors were encountered: