-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Map as a ScalarValue #11128
Comments
This only supports Map _type_, not Map literals, since Map isn't yet implemented in ScalarValue (apache#11128)
take |
I'm interested in this issue.
I think I can used a list of structs with the same type struct to implemented a basic version like:
Then, provide the HashMap (or others) implementation for the physical plan. |
I think ScalarValue::Map should follow the same pattern as
So that would mean a single element enum ScalarValue {
...
Map(Arc<MapArray>)
...
} Does that make sense? |
Many thanks! It looks good to me. I didn't notice this struct. I will try to follow this pattern to implement this. |
* feat: Support Map type in Substrait conversions This only supports Map _type_, not Map literals, since Map isn't yet implemented in ScalarValue (#11128) * fix clippy
* feat: Support Map type in Substrait conversions This only supports Map _type_, not Map literals, since Map isn't yet implemented in ScalarValue (apache#11128) * fix clippy
Is your feature request related to a problem or challenge?
ScalarValue does not currently support Maps, see e.g. #8262 (comment).
#6485 is probably related as well, though I'm not 100% sure
I ran into this when looking to implement Substrait -> DF conversion for MapType
Describe the solution you'd like
Implement ScalarValue::Map and all the related functionality
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: