-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement equality =
and inequality <>
support for StringView
#10919
Comments
I am glad to pick this ticket. |
This issue must wait until #10920 because there is currently no convenient way to create a |
I think you are right -- conveniently @XiangpengHao has one here #10925 |
Hi @Weijun-H , great to know you are working on this! |
BTW I made a branch to work on StringView in DataFusion: #10961 |
StringView comparison added in #10985 |
Is your feature request related to a problem or challenge?
Part of #10918,
[StringViewArray
](https://docs.rs/arrow/latest/arrow/array/type.StringViewArray.html) support in DataFusionThere are several queries in the clickbench suite like follows:
where
"MobilePhoneModel"
and"SearchPhrase"
are string columns with predicates (in this case checking for empty string)Describe the solution you'd like
In order to improve performance of these queries we will need the ability to actually compare
StringViewArrays
to constant strings (and likely to each other)Thus I would like to be able to run
StringViewColumn = scalar
StringViewColumn = StringViewColumn
(and likewise for BinaryView)
I basically want to to run the following queries (where table
foo
hasStringView
columns)Describe alternatives you've considered
I suspect we will need to update the coercion logic and maybe also the arrow equality kernels like https://docs.rs/arrow/latest/arrow/compute/kernels/cmp/fn.eq.html
Additional context
No response
The text was updated successfully, but these errors were encountered: