Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement compare_op for GenericBinaryView #5897

Closed
Tracked by #5374
XiangpengHao opened this issue Jun 15, 2024 · 3 comments · Fixed by #5900
Closed
Tracked by #5374

Implement compare_op for GenericBinaryView #5897

XiangpengHao opened this issue Jun 15, 2024 · 3 comments · Fixed by #5900
Assignees
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@XiangpengHao
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Currently the following test case(s) will fail:

    #[test]
    fn test_utf8_view_eq() {
        let values = vec![Some("small"), None, Some("larger than 12 bytes string")];
        let left = StringViewArray::from_iter(values.iter());
        let right = StringViewArray::from_iter(values.iter());
        crate::cmp::eq(&left, &right).unwrap();
    }

Because we haven't implemented the code to compare two view types in compare_op https://github.com/XiangpengHao/arrow-rs/blob/master/arrow-ord/src/cmp.rs#L227

I believe this is required to unblock apache/datafusion#10919

Describe the solution you'd like

The solution should be fairly simple.

Describe alternatives you've considered

Additional context

@XiangpengHao XiangpengHao added the enhancement Any new improvement worthy of a entry in the changelog label Jun 15, 2024
@XiangpengHao
Copy link
Contributor Author

take

@XiangpengHao
Copy link
Contributor Author

take

Seems arrow don't have the fancy take command as DataFusion's https://datafusion.apache.org/contributor-guide/index.html#finding-and-creating-issues-to-work-on

Can you assign me @alamb ?

@alamb alamb assigned alamb and XiangpengHao and unassigned alamb Jun 16, 2024
@alamb alamb changed the title Implement compare_op for view types Implement compare_op for GenericBinaryView Jun 17, 2024
@alamb alamb added the arrow Changes to the arrow crate label Jul 2, 2024
@alamb
Copy link
Contributor

alamb commented Jul 2, 2024

label_issue.py automatically added labels {'arrow'} from #5900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants